Skip to content

fix(parser): links the error cause with ParseError #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

tusharf5
Copy link
Contributor

@tusharf5 tusharf5 commented Jul 14, 2024

Summary

Changes

Please provide a summary of what's being changed

The ParseError links the passed error cause with the thrown error.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: fixes #2773


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@tusharf5 tusharf5 requested a review from a team July 14, 2024 20:10
@tusharf5 tusharf5 requested a review from a team as a code owner July 14, 2024 20:10
@boring-cyborg boring-cyborg bot added parser This item relates to the Parser Utility tests PRs that add or change tests labels Jul 14, 2024
Copy link

boring-cyborg bot commented Jul 14, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jul 14, 2024
@github-actions github-actions bot added the bug Something isn't working label Jul 14, 2024

This comment was marked as outdated.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 14, 2024
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 14, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to open this PR!

I have left a couple of comments that I think we should address before merging it.

@tusharf5
Copy link
Contributor Author

@dreamorosi Made the changes based on the feedback, thanks.

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the feedback, merging it!

@dreamorosi dreamorosi merged commit 34d0b55 into aws-powertools:main Jul 15, 2024
9 checks passed
Copy link

boring-cyborg bot commented Jul 15, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser This item relates to the Parser Utility size/S PR between 10-29 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseError no longer use the error.cause property
2 participants